guozhangwang commented on pull request #11496:
URL: https://github.com/apache/kafka/pull/11496#issuecomment-971818060


   Ah thanks @zzccctv that helps.
   
   I'm now wondering if it is very useful to print the KafkaConfigs in 
`updateDefaultConfig` for the cluster-wide configs. What do you think about 
only printing once in `updateBrokerConfig` since that's the final configs to be 
used in this specific broker during initialization anyways.
   
   If you agree, we can augment the `updateCurrentConfig` function with the 
`validateOnly` flag, which would be passed in as false in `updateDefaultConfig` 
so we only print it once.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to