rondagostino opened a new pull request #11503: URL: https://github.com/apache/kafka/pull/11503
The `controller.listener.names` config is currently checked for existence when the `process.roles` contains the controller role (i.e. `process.roles=controller` or `process.roles=broker,contrtoller`); it is not checked for existence when `process.roles=broker`. However, KRaft brokers have to talk to KRaft controllers, of course, and they do so by taking the first entry in the `controller.listener.names` list. Therefore, `controller.listener.names` is required in KRaft mode even when `process.roles=broker`. This patch performs the check being done in the `process.roles=controller` and `process.roles=broker,controller` cases to the `process.roles=broker` case: we make sure `controller.listener.names` is a non-empty subset of the listeners appearing in the `listeners` config. This entailed adding an entry to the KRaft Quickstart broker-only config file (confirmed to now work via a manual test) as well as adding the entry to the KRaft broker-only system test configs, which I tested locally with the following success: ``` ================================================================================ SESSION REPORT (ALL TESTS) ducktape version: 0.8.1 session_id: 2021-11-15--015 run time: 6 minutes 10.745 seconds tests run: 5 passed: 5 failed: 0 ignored: 0 ================================================================================ test_id: kafkatest.sanity_checks.test_bounce.TestBounce.test_simple_run.metadata_quorum=COLOCATED_KRAFT.quorum_size=3 status: PASS run time: 1 minute 41.968 seconds -------------------------------------------------------------------------------- test_id: kafkatest.sanity_checks.test_bounce.TestBounce.test_simple_run.metadata_quorum=REMOTE_KRAFT.quorum_size=3 status: PASS run time: 1 minute 35.705 seconds -------------------------------------------------------------------------------- test_id: kafkatest.sanity_checks.test_bounce.TestBounce.test_simple_run.metadata_quorum=COLOCATED_KRAFT.quorum_size=1 status: PASS run time: 56.347 seconds -------------------------------------------------------------------------------- test_id: kafkatest.sanity_checks.test_bounce.TestBounce.test_simple_run.metadata_quorum=REMOTE_KRAFT.quorum_size=1 status: PASS run time: 1 minute 8.743 seconds -------------------------------------------------------------------------------- test_id: kafkatest.sanity_checks.test_bounce.TestBounce.test_simple_run.metadata_quorum=ZK.quorum_size=1 status: PASS run time: 47.454 seconds -------------------------------------------------------------------------------- ``` ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
