showuon opened a new pull request #11426:
URL: https://github.com/apache/kafka/pull/11426


   It looks like Windows OS doesn't support `fsync` on directory. The same 
issues also happen on 
[LUCENE](https://issues.apache.org/jira/browse/LUCENE-5588) and 
[HDFS](https://issues.apache.org/jira/browse/HDFS-13586) projects. And the way 
they fix it is pretty much the same: to skip fsync directory on Windows OS. 
Here are the patches for both 
[LUCENE-5588](https://patch-diff.githubusercontent.com/raw/apache/lucenenet/pull/43.patch)
 and 
[HDFS-13586](https://issues.apache.org/jira/secure/attachment/12924032/HDFS-13586.001.patch).
 
   
   I followed their way to fix this issue. No tests added since it's just an OS 
check added, no logic change.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to