hachikuji commented on a change in pull request #11186:
URL: https://github.com/apache/kafka/pull/11186#discussion_r707673948



##########
File path: 
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala
##########
@@ -117,6 +117,8 @@ class BrokerMetadataPublisher(conf: KafkaConfig,
                        delta: MetadataDelta,
                        newImage: MetadataImage): Unit = {
     try {
+      debug(s"Publishing delta $delta with highest offset 
$newHighestMetadataOffset")

Review comment:
       I found it useful when debugging the failures here, so I thought it 
would come in handy when debugging system test failures as well. I guess if 
there were any concerns from a security perspective, it would be about the 
`ConfigurationDelta`. Perhaps if we want to err on the safe side, we could 
print the keys only? That might be good enough since it would probably be clear 
from the test context what the change was. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to