junrao commented on a change in pull request #11255:
URL: https://github.com/apache/kafka/pull/11255#discussion_r701230149
##########
File path: core/src/main/scala/kafka/controller/KafkaController.scala
##########
@@ -628,9 +628,11 @@ class KafkaController(val config: KafkaConfig,
topicDeletionManager.failReplicaDeletion(newOfflineReplicasForDeletion)
}
- // If replica failure did not require leader re-election, inform brokers
of the offline brokers
+ // If no partition has changed leader or ISR, no UpdateMetadataRequest is
sent through PartitionStateMachine
+ // and ReplicaStateMachine. In that case, we want to send an
UpdateMetadataRequest explicitly to
+ // propagate the information about the new offline brokers.
Review comment:
With this comment, we could just remove the comment on the next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
