rhauch commented on pull request #10112: URL: https://github.com/apache/kafka/pull/10112#issuecomment-910557464
Also, with my proposed approach, the `offsetWriter` is only used (directly or indirectly) within the `commitOffsets()` method. That means we could actually do without the `synchronized(this)` block around the `offsetWriter.beginFlush()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
