showuon commented on a change in pull request #11211: URL: https://github.com/apache/kafka/pull/11211#discussion_r697793805
########## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PersistentWindowStore.java ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.streams.state.internals; + +import org.apache.kafka.streams.state.WindowStore; + +public interface PersistentWindowStore<K, V> extends WindowStore<K, V> { Review comment: Could you add java doc for this interface to explain what and why we need this interface? ########## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PersistentSessionStore.java ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.streams.state.internals; + +import org.apache.kafka.streams.state.SessionStore; + +public interface PersistentSessionStore<K, AGG> extends SessionStore<K, AGG> { Review comment: Could you add java doc for this interface to explain what and why we need this interface? ########## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PersistentWindowStore.java ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.streams.state.internals; + +import org.apache.kafka.streams.state.WindowStore; + +public interface PersistentWindowStore<K, V> extends WindowStore<K, V> { Review comment: Also, 2 spaces before `entends` ########## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java ########## @@ -217,6 +230,24 @@ public V fetch(final K key, final long timeFrom, final long timeTo) { Objects.requireNonNull(key, "key cannot be null"); + + if (wrapped().persistent()) { + + final long actualWindowStartTime = getActualWindowStartTime(timeFrom); + + if (timeTo < actualWindowStartTime) { + return KeyValueIterators.emptyWindowStoreIterator(); + } + + return new MeteredWindowStoreIterator<>( + wrapped().fetch(keyBytes(key), actualWindowStartTime, timeTo), + fetchSensor, + streamsMetrics, + serdes, + time + ); Review comment: There are many duplicated codes for this section, do you think it'd better to make them a separate method? ########## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/PersistentSessionStore.java ########## @@ -0,0 +1,28 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.streams.state.internals; + +import org.apache.kafka.streams.state.SessionStore; + +public interface PersistentSessionStore<K, AGG> extends SessionStore<K, AGG> { Review comment: Also, 2 spaces before `entends` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
