cadonna commented on a change in pull request #11184:
URL: https://github.com/apache/kafka/pull/11184#discussion_r685276170
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -52,6 +52,15 @@ <h1>Upgrade Guide and API Changes</h1>
<li> restart all new ({{fullDotVersion}}) application instances </li>
</ul>
+ <p>
+ Since 3.0.0 release, Kafka Streams uses a newer RocksDB version which
bumped its footer version persisted on files.
+ This means that old versioned RocksDB would not be able to recognize
the bytes written by that newer versioned RocksDB,
Review comment:
I think starting the paragraph with "Downgrading from 3.0.0" is a good
idea since it makes immediately clear what this paragraph is about.
##########
File path: docs/streams/upgrade-guide.html
##########
@@ -52,6 +52,15 @@ <h1>Upgrade Guide and API Changes</h1>
<li> restart all new ({{fullDotVersion}}) application instances </li>
</ul>
+ <p>
+ Since 3.0.0 release, Kafka Streams uses a newer RocksDB version which
bumped its footer version persisted on files.
Review comment:
A minor comment: Wouldn't it be simpler to just state that the on-disk
format changed? Mentioning the footer version puts too much details in this
guide, IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
