mimaison commented on a change in pull request #10807:
URL: https://github.com/apache/kafka/pull/10807#discussion_r684229444
##########
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##########
@@ -2262,11 +2262,12 @@ class KafkaApisTest {
Optional.empty())).asJava
val fetchMetadata = new JFetchMetadata(0, 0)
val fetchContext = new FullFetchContext(time, new FetchSessionCache(1000,
100),
- fetchMetadata, fetchData, false, metadataCache.topicNamesToIds(), false)
+ fetchMetadata, fetchData, false, metadataCache.topicNamesToIds(), false,
"my-client-id")
Review comment:
Not that it matters but should we use something like
`principal=my-principal`?
Same below too.
##########
File path: core/src/main/scala/kafka/server/FetchSession.scala
##########
@@ -684,15 +686,15 @@ class FetchSessionCache(private val maxEntries: Int,
* @param now The current time in milliseconds.
* @return True if an entry was evicted; false otherwise.
*/
- def tryEvict(privileged: Boolean, key: EvictableKey, now: Long): Boolean =
synchronized {
+ def tryEvict(privileged: Boolean, key: EvictableKey, now: Long, evictor:
String): Boolean = synchronized {
// Try to evict an entry which is stale.
val lastUsedEntry = lastUsed.firstEntry
if (lastUsedEntry == null) {
trace("There are no cache entries to evict.")
false
} else if (now - lastUsedEntry.getKey.lastUsedMs > evictionMs) {
val session = lastUsedEntry.getValue
- trace(s"Evicting stale FetchSession ${session.id}.")
+ trace(s"Evicting stale FetchSession ${session.id} for $evictor")
Review comment:
Should we preserve the full stop here and below?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
