vvcephei commented on a change in pull request #11099:
URL: https://github.com/apache/kafka/pull/11099#discussion_r678766017
##########
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStreamThreadTest.java
##########
@@ -90,6 +92,13 @@ public String newStoreName(final String prefix) {
"store-"
);
+ final ProcessorSupplier<Object, Object, Void, Void> processorSupplier
= () ->
+ new ContextualProcessor<Object, Object, Void, Void>() {
+ @Override
+ public void process(final Record<Object, Object> record) {
+ }
Review comment:
Thanks for the context. While that might be a good idea, let's keep
these PRs more strictly scoped. I'm afraid adding in extra stuff will make it
harder for people in the future to understand which changes were part of this
transition and which weren't.
Offhand, I'd guess that there's another test somewhere verifying that global
stores actually function properly. I think you're right: this test is more
about verifying that the thread implementation works as desired.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
