ableegoldman commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r675292037
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/Windows.java
##########
@@ -40,7 +40,11 @@
// By default grace period is 24 hours for all windows,
// in other words we allow out-of-order data for up to a day
- protected static final long DEFAULT_GRACE_PERIOD_MS = 24 * 60 * 60 * 1000L;
+ // This behavior is now deprecated
+ protected static final long DEPRECATED_OLD_24_HR_GRACE_PERIOD = 24 * 60 *
60 * 1000L;
Review comment:
Yeah it's an internal config so I hope they wouldn't assume anything
from the name and extrapolate to what they can and can't use. That said, it
does appear in these classes which are public themselves, so users are still
going to see it. But the important thing is that it makes sense to us, the
devs, who will actually be using it -- I think
`DEPRECATED_DEFAULT_24_HR_GRACE_PERIOD` is a bit more clear, just need to sneak
the word "default" in there somewhere imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
