mjsax commented on pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#issuecomment-880159699


   > but when users upgrade the Streams apps to 3.0 we guarantee retention time 
T+X
   
   I don't agree to this statement. It's a bug in the implementation (that this 
PR fixes) that we keep data for T+X, but the contract to guarantee that data is 
preserved (only) up to T does not change IMHO.
   
   Overall, the PR LGTM. If I read the code of this PR and the previous PRs 
correctly, it should put us back to the 2.8 behavior. We need to include the 
fix for JoinWindows though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to