lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r669865915
##########
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java
##########
@@ -51,12 +57,12 @@ public boolean assign(final Map<UUID, ClientState> clients,
final SortedSet<TaskId> statefulTasks = new TreeSet<>(statefulTaskIds);
final TreeMap<UUID, ClientState> clientStates = new TreeMap<>(clients);
- assignActiveStatefulTasks(clientStates, statefulTasks);
+ final Map<TaskId, UUID> statefulTasksClientMappings =
assignActiveStatefulTasks(clientStates, statefulTasks);
assignStandbyReplicaTasks(
clientStates,
- statefulTasks,
- configs.numStandbyReplicas
+ statefulTasksClientMappings,
+ configs
);
Review comment:
Sure! done.
Personal preference. Having all the strategies of standby task assignment
implementations in a single class makes unit testing a bit easier. But I do
agree that removing one extra class is indeed good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
