vamossagar12 commented on pull request #10877:
URL: https://github.com/apache/kafka/pull/10877#issuecomment-879870668


   > I think this looks pretty good (as far as I can tell), but the important 
thing is going to be the tests, since it's hard to verify just by looking 
whether we hit every place this is needed. One thing I was wondering was 
whether we have any tests for this with IQ (Interactive Queries) -- if not, an 
integration test that tries to run `prefixScan` using IQ should definitely be 
added
   
   I have added a test for IQ. Some reason, I wasn't able to run the test on my 
local as I was getting a build failure due to scala test classes. I would watch 
out for the status of the tests here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to