[GitHub] [kafka] mjsax commented on a change in pull request #10953: MINOR: Default GRACE with Old API should set as 24H minus window-size / inactivity-gap

[GitBox]

mjsax commented on a change in pull request #10953:
URL: https://github.com/apache/kafka/pull/10953#discussion_r668344535



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/SessionWindows.java
##########
@@ -140,7 +140,7 @@ public static SessionWindows with(final Duration 
inactivityGap) {
         final String msgPrefix = 
prepareMillisCheckFailMsgPrefix(inactivityGap, "inactivityGap");
         final long inactivityGapMs = 
validateMillisecondDuration(inactivityGap, msgPrefix);
 
-        return new SessionWindows(inactivityGapMs, 
DEPRECATED_OLD_24_HR_GRACE_PERIOD);
+        return new SessionWindows(inactivityGapMs, 
Math.max(DEPRECATED_OLD_24_HR_GRACE_PERIOD - inactivityGapMs, 0));

Review comment:
       Is this correct? The old `maintainMs` did use `Math.max(grace, 
inactivityGap)` ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org