showuon commented on a change in pull request #10794:
URL: https://github.com/apache/kafka/pull/10794#discussion_r667293695
##########
File path: core/src/test/scala/unit/kafka/network/RequestChannelTest.scala
##########
@@ -179,6 +184,108 @@ class RequestChannelTest {
assertTrue(isValidJson(RequestConvertToJson.request(alterConfigs.loggableRequest).toString))
}
+ @Test
+ def
testEnvelopeBuildResponseSendShouldReturnNoErrorIfInnerResponseHasNoError():
Unit = {
+ val channelRequest = buildRequestWithEnvelope()
Review comment:
Put the `buildRequestWithEnvelope` method in TestUtils class to share
between `KafkaApisTest` and `RequestChannelTest`. And also use
`MetadataRequest` as input. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
