0x1991babe opened a new pull request #11014: URL: https://github.com/apache/kafka/pull/11014
This is *extremely, extremely* minor. We are using default values for some serialization logic, and I noticed in doing a review for https://github.com/0x1991babe/kafka-protocol-rs/issues/1 that there's an inconsistency between `FetchSnapshotResponse` and `FetchSnapshot`, namely, `FetchSnapshot` [provides default values for these fields](https://github.com/apache/kafka/blob/trunk/clients/src/main/resources/common/message/FetchResponse.json#L73-L74). Without defaults, we're constructing the default with `0`, which I'm concerned may be a valid state for the struct (as opposed to `-1`). It looks like this is for Raft (??) so may actually be totally and completely irrelevant for end users of our lib, in which case feel free to close. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
