ijuma commented on a change in pull request #10868:
URL: https://github.com/apache/kafka/pull/10868#discussion_r667022227
##########
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##########
@@ -74,7 +74,15 @@ class ControllerApis(val requestChannel: RequestChannel,
val authHelper = new AuthHelper(authorizer)
val requestHelper = new RequestHandlerHelper(requestChannel, quotas, time)
- private val aclApis = new AclApis(authHelper, authorizer, requestHelper,
"controller", config)
+ private[server] val aclApis = new AclApis(authHelper, authorizer,
requestHelper, "controller", config)
+ private var _isClosed = false
+
+ def isClosed: Boolean = _isClosed
Review comment:
Can this just return whether aclApis is closed?
##########
File path: core/src/main/scala/kafka/server/AclApis.scala
##########
@@ -48,10 +48,11 @@ class AclApis(authHelper: AuthHelper,
this.logIdent = "[AclApis-%s-%s] ".format(name, config.nodeId)
private val alterAclsPurgatory =
new DelayedFuturePurgatory(purgatoryName = "AlterAcls", brokerId =
config.nodeId)
+ private var _isClosed = false
- def close(): Unit = {
- alterAclsPurgatory.shutdown()
- }
+ def isClosed: Boolean = _isClosed
Review comment:
Can this just return whether `alterAclsPurgatory` is closed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
