hachikuji commented on a change in pull request #10995:
URL: https://github.com/apache/kafka/pull/10995#discussion_r666348755
##########
File path: tests/docker/ducker-ak
##########
@@ -185,6 +185,12 @@ must_popd() {
popd &> /dev/null || die "failed to popd"
}
+echo_and_do() {
+ local cmd="${@}"
+ echo "${cmd}"
+ ${cmd}
Review comment:
The logic through `must_do`, which we were doing previously also
redirects output and checks the command return. Should we do something similar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
