showuon commented on pull request #10977: URL: https://github.com/apache/kafka/pull/10977#issuecomment-875220116
@wuYin > This small change is mainly to unify the way to determine if the user has set the default value Yes, I know, so I think this line should also be updated. https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java#L1146 ``` NO_DEFAULT_VALUE.equals(defaultValue) ? NO_DEFAULT_VALUE : parseType(name, defaultValue, type); ``` It is also trying to determine if the default value is set, so, we can update to: ``` hasDefault() ? parseType(name, defaultValue, type) : NO_DEFAULT_VALUE; ``` What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
