izzyacademy commented on a change in pull request #10926:
URL: https://github.com/apache/kafka/pull/10926#discussion_r661801807



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/JoinWindows.java
##########
@@ -177,7 +204,9 @@ public long size() {
      * @param afterWindowEnd The grace period to admit out-of-order events to 
a window.
      * @return this updated builder
      * @throws IllegalArgumentException if the {@code afterWindowEnd} is 
negative of can't be represented as {@code long milliseconds}
+     * @deprecated since 3.0 Use {@link 
#ofTimeDifferenceWithNoGrace(Duration)} instead
      */
+    @Deprecated
     public JoinWindows grace(final Duration afterWindowEnd) throws 
IllegalArgumentException {

Review comment:
       These are the JIRA tickets to track the work to fix the unit tests and 
javadocs
   
   Improve Javadocs for API Changes from KIP-633
   https://issues.apache.org/jira/browse/KAFKA-13021
   
   Migrate all Tests to New API and Remove Suppression for Deprecation Warnings 
related to KIP-633
   https://issues.apache.org/jira/browse/KAFKA-12994




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to