kpatelatwork commented on a change in pull request #10822:
URL: https://github.com/apache/kafka/pull/10822#discussion_r660953271
##########
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java
##########
@@ -210,6 +211,15 @@ public void onDeletion(ConnectorTaskId id) {
statusBackingStore.put(new TaskStatus(id, TaskStatus.State.DESTROYED,
workerId, generation()));
}
+ public void onRestart(String connector) {
Review comment:
@kkonstantine you are right. Do you mind if we do this work in a
follow-up PR? The reason I ask is because if we add it to the listener then it
becomes part of the interface and this would require me to retrofit the
listener event into the old restartTask and restartConnector API for backward
compatibility reasons and it can be big change to this already big PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
