kkonstantine commented on a change in pull request #10822:
URL: https://github.com/apache/kafka/pull/10822#discussion_r660867874



##########
File path: 
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java
##########
@@ -210,6 +211,15 @@ public void onDeletion(ConnectorTaskId id) {
         statusBackingStore.put(new TaskStatus(id, TaskStatus.State.DESTROYED, 
workerId, generation()));
     }
 
+    public void onRestart(String connector) {

Review comment:
       Did you compare it with other methods? My understanding is that 
`onDelete` is the same in that respect and exists on the `Listener` as well. 
But I might have skimmed too quickly through the code




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to