mimaison commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r659636618



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiDriver.java
##########
@@ -250,6 +252,13 @@ public void onFailure(
                 .filter(future.lookupKeys()::contains)
                 .collect(Collectors.toSet());
             retryLookup(keysToUnmap);
+
+        } else if (t instanceof NoBatchedFindCoordinatorsException) {

Review comment:
       `AdminApiDriver` was still evolving rapidly while I was implementing 
this KIP so I went for the straighforward approach.
   
   But I agree, it would be best to avoid this type of logic here. The goal 
would be to find a mechanism that works for all clients. @tombentley suggested 
an alternative option in 
https://github.com/apache/kafka/pull/10743#discussion_r649872433. 
   
   I've not had the time to look into better alternatives yet.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to