dajac commented on a change in pull request #10743:
URL: https://github.com/apache/kafka/pull/10743#discussion_r658526557
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/internals/CoordinatorKey.java
##########
@@ -24,7 +24,7 @@
public final String idValue;
Review comment:
@skaundinya15 I don't understand why we would want to return
`CoordinatorKey` in some results. Do we really have to? It seems that we could
unwrap it depending on the context and only expose what the user need (e.g.
group id).
Personally, I believe that we should strive for keeping all the constructors
of `*Result` classes package private for the time being until KIP-692 is
accepted, if it will.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
