cmccabe commented on a change in pull request #10812:
URL: https://github.com/apache/kafka/pull/10812#discussion_r658323339
##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -1049,6 +1052,7 @@ object KafkaConfig {
.defineInternal(BrokerHeartbeatIntervalMsProp, INT,
Defaults.BrokerHeartbeatIntervalMs, null, MEDIUM, BrokerHeartbeatIntervalMsDoc)
.defineInternal(BrokerSessionTimeoutMsProp, INT,
Defaults.BrokerSessionTimeoutMs, null, MEDIUM, BrokerSessionTimeoutMsDoc)
.defineInternal(MetadataLogDirProp, STRING, null, null, HIGH,
MetadataLogDirDoc)
+ .defineInternal(MetadataSnapshotMinNewRecordBytesProp, INT,
Defaults.MetadataSnapshotMinNewRecordBytes, atLeast(1), HIGH,
MetadataSnapshotMinNewRecordBytesDoc)
Review comment:
This should certainly be a LONG, not INT. I could certainly imagine a
snapshot bigger than 2GB (although hopefully that won't be the norm for a while)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
