thomaskwscott commented on a change in pull request #10760: URL: https://github.com/apache/kafka/pull/10760#discussion_r657004623
########## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ########## @@ -4298,6 +4296,39 @@ void handleFailure(Throwable throwable) { } } } + + @Override + boolean handleUnsupportedVersionException(UnsupportedVersionException exception) { + if (supportsMaxTimestamp) { + supportsMaxTimestamp = false; + + // fail any unsupported futures and remove partitions from the downgraded retry + List<ListOffsetsTopic> topicsToRemove = new ArrayList<>(); + partitionsToQuery.stream().forEach( + t -> { + List<ListOffsetsPartition> partitionsToRemove = new ArrayList<>(); + t.partitions().stream() + .filter(p -> p.timestamp() == ListOffsetsRequest.MAX_TIMESTAMP) + .forEach( + p -> { + futures.get(new TopicPartition(t.name(), p.partitionIndex())) + .completeExceptionally( + new UnsupportedVersionException( + "Broker " + brokerId + + " does not support MAX_TIMESTAMP offset spec")); + partitionsToRemove.add(p); + + }); + t.partitions().removeAll(partitionsToRemove); + if (t.partitions().isEmpty()) topicsToRemove.add(t); + } + ); + partitionsToQuery.removeAll(topicsToRemove); Review comment: agreed, looks much neater. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org