jsancio commented on pull request #10891: URL: https://github.com/apache/kafka/pull/10891#issuecomment-863485120
Thanks for the review @cmccabe > For now, I think it's OK to have TimelineInteger and TimelineLong always "reset" to 0. All the uses we have now have that behavior. Maybe we can avoid storing the "init" value if nobody needs a value other than 0 (yet?). Sounds good to me. Done. > I think "reset" should be basically identical to the constructor for the hash table(s). I assumed that you meant that the constructors for `TimelineInteger` and `TimelineLong` should not support an initial value like the constructor for `SnapshottableHashTable`. Let me know if you meant something else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
