[GitHub] [kafka] IgnacioAcunaF commented on a change in pull request #10858: KAFKA-12926: ConsumerGroupCommand's java.lang.NullPointerException at negative offsets while running kafka-consumer-groups.sh

[GitBox]

IgnacioAcunaF commented on a change in pull request #10858:
URL: https://github.com/apache/kafka/pull/10858#discussion_r652187497



##########
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##########
@@ -580,7 +582,7 @@ object ConsumerGroupCommand extends Logging {
             groupId,
             Option(consumerGroup.coordinator),
             unassignedPartitions.keySet.toSeq,
-            unassignedPartitions.map { case (tp, offset) => tp -> 
Some(offset.offset) },
+            unassignedPartitions.map { case (tp, offset) => tp -> 
getPartitionOffset(tp) },

Review comment:
       Same with the previous approach, it could be from:
   **From**:
   ```
   val rowsWithoutConsumer = if (unassignedPartitions.nonEmpty) {
             collectConsumerAssignment(
               groupId,
               Option(consumerGroup.coordinator),
               unassignedPartitions.keySet.toSeq,
               unassignedPartitions.map { case (tp, offset) => tp -> 
getPartitionOffset(tp) },
               Some(MISSING_COLUMN_VALUE),
               Some(MISSING_COLUMN_VALUE),
               Some(MISSING_COLUMN_VALUE)).toSeq
           } else
             Seq.empty
   ```
   **To**:
   ```
   val rowsWithoutConsumer = if (unassignedPartitions.nonEmpty) {
             collectConsumerAssignment(
               groupId,
               Option(consumerGroup.coordinator),
               unassignedPartitions.keySet.toSeq,
               getPartitionOffsets(unassignedPartitions.keySet.toSeq),
               Some(MISSING_COLUMN_VALUE),
               Some(MISSING_COLUMN_VALUE),
               Some(MISSING_COLUMN_VALUE)).toSeq
           } else
             Seq.empty
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org