jsancio commented on a change in pull request #10749:
URL: https://github.com/apache/kafka/pull/10749#discussion_r649429301
##########
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##########
@@ -372,27 +371,23 @@ private void maybeFireLeaderChange() {
@Override
public void initialize() {
- try {
- quorum.initialize(new OffsetAndEpoch(log.endOffset().offset,
log.lastFetchedEpoch()));
+ quorum.initialize(new OffsetAndEpoch(log.endOffset().offset,
log.lastFetchedEpoch()));
- long currentTimeMs = time.milliseconds();
- if (quorum.isLeader()) {
- throw new IllegalStateException("Voter cannot initialize as a
Leader");
- } else if (quorum.isCandidate()) {
- onBecomeCandidate(currentTimeMs);
- } else if (quorum.isFollower()) {
- onBecomeFollower(currentTimeMs);
- }
+ long currentTimeMs = time.milliseconds();
+ if (quorum.isLeader()) {
+ throw new IllegalStateException("Voter cannot initialize as a
Leader");
+ } else if (quorum.isCandidate()) {
+ onBecomeCandidate(currentTimeMs);
+ } else if (quorum.isFollower()) {
+ onBecomeFollower(currentTimeMs);
+ }
- // When there is only a single voter, become candidate immediately
- if (quorum.isVoter()
- && quorum.remoteVoters().isEmpty()
- && !quorum.isCandidate()) {
+ // When there is only a single voter, become candidate immediately
+ if (quorum.isVoter()
+ && quorum.remoteVoters().isEmpty()
+ && !quorum.isCandidate()) {
- transitionToCandidate(currentTimeMs);
- }
- } catch (IOException e) {
- throw new RuntimeException(e);
+ transitionToCandidate(currentTimeMs);
Review comment:
Leaving this note for future readers. My comments above are not
accurate. I misread the diff generated by GitHub. When I wrote the comment, I
was under the impression that the old code was handling, wrapping and
re-throwing the `IOException`.
Instead the old code wrapped and re-threw the `IOException`; it was not
handling the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
