cadonna commented on a change in pull request #10428: URL: https://github.com/apache/kafka/pull/10428#discussion_r646431916
########## File path: core/src/test/java/kafka/test/MockController.java ########## @@ -250,20 +238,18 @@ private ApiError incrementalAlterResource(ConfigResource resource, } @Override - public CompletableFuture<AlterPartitionReassignmentsResponseData> - alterPartitionReassignments(AlterPartitionReassignmentsRequestData request) { + public CompletableFuture<AlterPartitionReassignmentsResponseData> alterPartitionReassignments(AlterPartitionReassignmentsRequestData request) { throw new UnsupportedOperationException(); } @Override - public CompletableFuture<ListPartitionReassignmentsResponseData> - listPartitionReassignments(ListPartitionReassignmentsRequestData request) { + public CompletableFuture<ListPartitionReassignmentsResponseData> listPartitionReassignments(ListPartitionReassignmentsRequestData request) { throw new UnsupportedOperationException(); } @Override public CompletableFuture<Map<ConfigResource, ApiError>> legacyAlterConfigs( - Map<ConfigResource, Map<String, String>> newConfigs, boolean validateOnly) { + Map<ConfigResource, Map<String, String>> newConfigs, boolean validateOnly) { Review comment: Could you put the first parameter in the same line as the method name and put the remaining parameters on their own line as I proposed? Could you do the same for `incrementalAlterConfigs()`? If anybody does not like this style, we can still delete ``` <setting id="org.eclipse.jdt.core.formatter.alignment_for_parameters_in_constructor_declaration" value="18"/> <setting id="org.eclipse.jdt.core.formatter.alignment_for_parameters_in_method_declaration" value="18"/> ``` from the formatter configuration, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org