showuon commented on a change in pull request #10690:
URL: https://github.com/apache/kafka/pull/10690#discussion_r636611321
##########
File path:
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java
##########
@@ -246,8 +246,8 @@
public static final String ENABLE_IDEMPOTENCE_CONFIG =
"enable.idempotence";
public static final String ENABLE_IDEMPOTENCE_DOC = "When set to 'true',
the producer will ensure that exactly one copy of each message is written in
the stream. If 'false', producer "
+ "retries due to
broker failures, etc., may write duplicates of the retried message in the
stream. "
- + "Note that enabling
idempotence requires <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION + "</code>
to be less than or equal to 5, "
- + "<code>" +
RETRIES_CONFIG + "</code> to be greater than 0 and <code>" + ACKS_CONFIG +
"</code> must be 'all'. If these values "
+ + "Note that enabling
idempotence requires <code>" + MAX_IN_FLIGHT_REQUESTS_PER_CONNECTION + "</code>
to be less than or equal to 5 (with message ordering preserved for any
allowable vlaue), "
Review comment:
typo: with message ordering preserved for any allowable **vlaue** -->
**value**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
