ijuma commented on a change in pull request #10703:
URL: https://github.com/apache/kafka/pull/10703#discussion_r633025431
##########
File path:
streams/src/test/java/org/apache/kafka/streams/kstream/internals/SlidingWindowedCogroupedKStreamImplTest.java
##########
@@ -156,7 +156,7 @@ public void slidingWindowAggregateStreamsTest() {
final TestInputTopic<String, String> testInputTopic =
driver.createInputTopic(
TOPIC, new StringSerializer(), new StringSerializer());
final TestOutputTopic<Windowed<String>, String> testOutputTopic =
driver.createOutputTopic(
- OUTPUT, new TimeWindowedDeserializer<>(new
StringDeserializer()), new StringDeserializer());
+ OUTPUT, new TimeWindowedDeserializer<>(new
StringDeserializer(), Long.MAX_VALUE), new StringDeserializer());
Review comment:
I've changed the code to pass `500L`, but the `TestRecord` change causes
compilation errors since we explicitly use a `nonWindowedRecord`:
> results.add(nonWindowedRecord);
Can we address that separately? I think we can focus on fixing the
deprecation warning in this PR, if that's ok with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
