[GitHub] [kafka] lbradstreet commented on a change in pull request #10606: KAFKA-12728: version upgrades: gradle (6.8.3 -->> 7.0.2) and gradle shadow plugin (6.1.0 -->> 7.0.0)

[GitBox]

lbradstreet commented on a change in pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#discussion_r632971762



##########
File path: gradle/wrapper/gradle-wrapper.properties
##########
@@ -1,5 +1,6 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.8.3-all.zip
+distributionSha256Sum=13bf8d3cf8eeeb5770d19741a59bde9bd966dd78d17f1bbad787a05ef19d1c2d

Review comment:
       Including the checksum validation is a good change,  but it does result 
in a somewhat confusing message from IntelliJ if you have the android plugin 
enabled (which is the default). You can fairly easily progress by clicking the 
"Use xxxxx" link to allow the validation or disabling the android plugin, but I 
expect a few people to be confused by this along the way.
   
   
![image](https://user-images.githubusercontent.com/252189/118367010-7681d580-b555-11eb-8e3b-b4ea8cf140b7.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org