[GitHub] [kafka] vitojeng commented on a change in pull request #10668: MINOR: Apply try-with-resource to KafkaStreamsTest

[GitBox]

vitojeng commented on a change in pull request #10668:
URL: https://github.com/apache/kafka/pull/10668#discussion_r630705257



##########
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##########
@@ -525,14 +525,13 @@ public void testStateGlobalThreadClose() throws Exception 
{
                 () -> streams.state() == KafkaStreams.State.PENDING_ERROR,
                 "Thread never stopped."
             );
-        } finally {
             streams.close();

Review comment:
       @mjsax The line 532(original) wait for the streams state equal to 
**ERROR** after streams closed. 
   Although this test case will pass if we remove `close()`, but it seems we 
might be better to retain `close()`?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org