[GitHub] [kafka] spena commented on a change in pull request #10613: KAFKA-10847: Set shared outer store to an in-memory store when in-memory stores are supplied

[GitBox]

spena commented on a change in pull request #10613:
URL: https://github.com/apache/kafka/pull/10613#discussion_r625811787



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java
##########
@@ -155,7 +156,7 @@ public long get() {
 
             final String outerJoinStoreName = userProvidedBaseStoreName == 
null ? outerJoinStoreGeneratedName : userProvidedBaseStoreName + 
outerJoinSuffix;
 
-            outerJoinWindowStore = 
Optional.of(sharedOuterJoinWindowStoreBuilder(outerJoinStoreName, windows, 
streamJoinedInternal));
+            outerJoinWindowStore = 
Optional.of(sharedOuterJoinWindowStoreBuilder(outerJoinStoreName, windows, 
streamJoinedInternal, persistent));

Review comment:
       No reasons at all. I just chose one side to decide whether go mem or 
rocks. Left seems the only side that always is True either is Left or Outer. I 
was thinking of maybe going mem if in left joins, the left side is mem; or if 
in outer joins, both sides left/right are mem. What do you think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org