jsancio commented on a change in pull request #10085:
URL: https://github.com/apache/kafka/pull/10085#discussion_r624200356



##########
File path: raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java
##########
@@ -966,6 +967,54 @@ public void verify() {
         }
     }
 
+    private static class SnapshotAtLogStart implements Invariant {

Review comment:
       Good catch. I made some improvements After the improvements the 
simulation time went from 1 minute in trunk to a 1:41 minutes for this PR. It 
looks like a good amount of that time is spent in 
MockLog.validateOffsetAndEpoch. Let me see what we can do but we can also 
remove that functionality from the verification.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to