gharris1727 commented on a change in pull request #10475:
URL: https://github.com/apache/kafka/pull/10475#discussion_r624048885
##########
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/TestPlugins.java
##########
@@ -143,16 +176,35 @@ public static void assertAvailable() throws
AssertionError {
public static List<String> pluginPath() {
Review comment:
Yes, but plugins are now no longer unique by name. The
`test.plugins.ReadVersionFromResource` plugin class is now provided by two
different plugin jars, and when the DelegatingClassLoader attempts to load it,
it is arbitrary which one is chosen.
For example, if you set up Plugins with this path, and load the
`test.plugins.ReadVersionFromResource`, will you get v1 or v2? I believe it
depends on iteration order in the hashmap, and so happens to be deterministic
here but not in general.
Currently, Connect does not have first class support for plugin paths with
duplicate plugins due to this ambiguity, so I don't think this method should
return a plugin path which is unsupported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
