ableegoldman commented on a change in pull request #10608:
URL: https://github.com/apache/kafka/pull/10608#discussion_r622718411



##########
File path: 
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateDirectoryTest.java
##########
@@ -315,7 +314,7 @@ public void 
shouldCleanupStateDirectoriesWhenLastModifiedIsLessThanNowMinusClean
     }
 
     @Test
-    public void shouldCleanupObsoleteStateDirectoriesOnlyOnce() {
+    public void 
shouldCleanupObsoleteTaskDirectoriesAndDeleteTheDirectoryItself() {

Review comment:
       This test was originally added when we fixed a bug where Streams was 
continuously attempting to clean "empty" task directories and logging the 
`"Deleting obsolete state directory..."` message. The root cause of this was 
that we couldn't delete the task directory itself due to the lock file, so we 
just left empty directories behind. This PR fixes that, so I adapted the PR to 
test this new functionality since the old test wouldn't really make sense any 
more




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to