kowshik commented on a change in pull request #10478:
URL: https://github.com/apache/kafka/pull/10478#discussion_r613679576
##########
File path: core/src/main/scala/kafka/log/Log.scala
##########
@@ -2586,11 +1999,15 @@ object Log {
logDirFailureChannel: LogDirFailureChannel,
lastShutdownClean: Boolean = true,
topicId: Option[Uuid],
- keepPartitionMetadataFile: Boolean): Log = {
+ keepPartitionMetadataFile: Boolean = true): Log = {
+ // create the log directory if it doesn't exist
+ Files.createDirectories(dir.toPath)
val topicPartition = Log.parseTopicPartitionName(dir)
- val producerStateManager = new ProducerStateManager(topicPartition, dir,
maxProducerIdExpirationMs)
- new Log(dir, config, logStartOffset, recoveryPoint, scheduler,
brokerTopicStats, time, maxProducerIdExpirationMs,
- producerIdExpirationCheckIntervalMs, topicPartition,
producerStateManager, logDirFailureChannel, lastShutdownClean, topicId,
keepPartitionMetadataFile)
+ val logLoader = new LogLoader(dir, topicPartition, config, scheduler,
time, logDirFailureChannel)
Review comment:
Done. I've updated the PR converting LogLoader into an object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
