dongjinleekr commented on pull request #10428: URL: https://github.com/apache/kafka/pull/10428#issuecomment-819606373
Hi @cadonna, Thanks again for your detailed review. Here is the update. Following your suggestions, I tried some other configurations. First of all, there is no way to use automatic import ordering only - without any configuration, the formatter formats the code with its default configuration. So, we have to find the least-effecting configuration. The major differences between the last draft are like the following: - **Remove line wrapping rule for 120 characters.** - **Comment is not formatted anymore.** - Remove bracing-related rules. But, I kept the other rules, like: - As of present, both of 4 space indenting and 8 space indenting are co-existing in the code. I configured to use 4 space indenting for its majority. - Several styles for the parameter formatting for the class and method definition also exist in the code. It is configured to the least-effecting configuration. Please have a look when you are free. Thanks again for the review! +1. It would be better to check how the new configuration formats streams module. I tested with that module, for it has so many `*.java` files. :wink: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
