vitojeng edited a comment on pull request #9821:
URL: https://github.com/apache/kafka/pull/9821#issuecomment-819233511
> Awesome. I can help get this current PR reviewed and merged from here, and
probably find you someone else to review the next PR(s) since I'm pretty busy 🙂
Great, thanks.
> Now, regarding your last question on this PR: am I reading it correctly
that we just don't ever throw `InvalidStateStoreException` from
`allMetadataForStore` or `queryMetadataForKey` at the moment, therefore it
doesn't make sense to throw UnknownStateStoreException from these methods as
part of this KIP?
>
> Personally, I think it's ok to just throw whatever exception makes sense
from wherever in the code it makes sense to do so. You can send a quick update
note to the KIP thread to say that you're making this amendment, and if anyone
has a concern they can respond there.
@ableegoldman I just feel that I may need to point out this(will break the
API for the new exception).
Your suggestion is great. I'm happy to update the KIP and update the PR for
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
