ableegoldman edited a comment on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-819206522
Awesome. I can help get this current PR reviewed and merged from here, and probably find you someone else to review the next PR(s) since I'm pretty busy 🙂 Now, regarding your last question on this PR: am I reading it correctly that we just don't ever throw `InvalidStateStoreException` from `allMetadataForStore` or `queryMetadataForKey` at the moment, therefore it doesn't make sense to throw UnknownStateStoreException from these methods as part of this KIP? Personally, I think it's ok to just throw whatever exception makes sense from wherever in the code it makes sense to do so. You can send a quick update note to the KIP thread to say that you're making this amendment, and if anyone has a concern they can respond there. For this specific case: it certainly seems to make sense that `allMetadataForStore` would throw an UnknownStateStoreException if a store name was passed in that's, well, unknown. I do see that we don't currently throw anything like that, and it looks like we would just return nothing if an invalid store was passed in, but that was probably just an oversight -- I don't see why it should behave any differently from `KafkaStreams#store`. Same goes for `queryMetadataForKey` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
