hachikuji commented on a change in pull request #10506:
URL: https://github.com/apache/kafka/pull/10506#discussion_r611840016



##########
File path: 
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java
##########
@@ -66,7 +66,8 @@
 
     /** <code>max.poll.records</code> */
     public static final String MAX_POLL_RECORDS_CONFIG = "max.poll.records";
-    private static final String MAX_POLL_RECORDS_DOC = "The maximum number of 
records returned in a single call to poll().";
+    private static final String MAX_POLL_RECORDS_DOC = "The maximum number of 
records returned in a single call to poll()."
+        + " Note, that <code>" + MAX_POLL_RECORDS_CONFIG + "</code> does not 
impact the underlying fetching behavior.";

Review comment:
       Maybe add one more sentence:
   
   > .. underlying fetch behavior. The consumer will cache the records from 
each Fetch request and return them incrementally from each `poll`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to