ijuma commented on a change in pull request #10502:
URL: https://github.com/apache/kafka/pull/10502#discussion_r611064000



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/KafkaClientSupplier.java
##########
@@ -31,29 +30,14 @@
  * @see KafkaStreams#KafkaStreams(Topology, java.util.Properties, 
KafkaClientSupplier)
  */
 public interface KafkaClientSupplier {
-    /**
-     * Create an {@link AdminClient} which is used for internal topic 
management.
-     *
-     * @param config Supplied by the {@link java.util.Properties} given to the 
{@link KafkaStreams}
-     * @return an instance of {@link AdminClient}
-     * @deprecated Not called by Kafka Streams, which now uses {@link 
#getAdmin} instead.
-     */
-    @Deprecated
-    default AdminClient getAdminClient(final Map<String, Object> config) {
-        throw new UnsupportedOperationException("Direct use of this method is 
deprecated. " +
-            "Implementations of KafkaClientSupplier should implement the 
getAdmin() method instead. " +
-            "The method will be removed in a future release.");
-    }
-
     /**
      * Create an {@link Admin} which is used for internal topic management.
      *
      * @param config Supplied by the {@link java.util.Properties} given to the 
{@link KafkaStreams}
      * @return an instance of {@link Admin}
      */
-    @SuppressWarnings("deprecation")
     default Admin getAdmin(final Map<String, Object> config) {
-        return getAdminClient(config);
+        throw new UnsupportedOperationException("Implementations of 
KafkaClientSupplier should implement the getAdmin() method.");

Review comment:
       Would we want to remove this default implementation too? Not saying we 
should, but what's the benefit?

##########
File path: 
streams/src/main/java/org/apache/kafka/streams/KafkaClientSupplier.java
##########
@@ -31,29 +30,14 @@
  * @see KafkaStreams#KafkaStreams(Topology, java.util.Properties, 
KafkaClientSupplier)
  */
 public interface KafkaClientSupplier {
-    /**
-     * Create an {@link AdminClient} which is used for internal topic 
management.
-     *
-     * @param config Supplied by the {@link java.util.Properties} given to the 
{@link KafkaStreams}
-     * @return an instance of {@link AdminClient}
-     * @deprecated Not called by Kafka Streams, which now uses {@link 
#getAdmin} instead.
-     */
-    @Deprecated
-    default AdminClient getAdminClient(final Map<String, Object> config) {
-        throw new UnsupportedOperationException("Direct use of this method is 
deprecated. " +
-            "Implementations of KafkaClientSupplier should implement the 
getAdmin() method instead. " +
-            "The method will be removed in a future release.");
-    }
-
     /**
      * Create an {@link Admin} which is used for internal topic management.
      *
      * @param config Supplied by the {@link java.util.Properties} given to the 
{@link KafkaStreams}
      * @return an instance of {@link Admin}
      */
-    @SuppressWarnings("deprecation")
     default Admin getAdmin(final Map<String, Object> config) {
-        return getAdminClient(config);
+        throw new UnsupportedOperationException("Implementations of 
KafkaClientSupplier should implement the getAdmin() method.");

Review comment:
       Would we want to remove this default implementation too? Not saying we 
should, but what's the benefit of keeping it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to