guozhangwang commented on a change in pull request #10462:
URL: https://github.com/apache/kafka/pull/10462#discussion_r608887445
##########
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java
##########
@@ -161,7 +181,7 @@ public void process(final K key, final V1 value) {
//
// the condition below allows us to process the late
record without the need
// to hold it in the temporary outer store
- if (timeTo < maxStreamTime) {
+ if (internalOuterJoinFixDisabled || timeTo <
maxStreamTime) {
Review comment:
We can refactor it as:
```
if (!outerJoinWindowStore.isPresent() || timeTo < maxStreamTime) {
context().forward(key, joiner.apply(key, value, null));
} else {
}
```
Then `internalOuterJoinFixDisabled` can just be a local variable instead of
a class field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
