[ https://issues.apache.org/jira/browse/KAFKA-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17314723#comment-17314723 ]
Justin Mclean commented on KAFKA-12602: --------------------------------------- Looking at the proposed changes, some changes may need to be made to the binary NOTICE file due to including of ALv2 dependancies. I also see you include general MIT and BSD licenses. This is probably OK but it would be better to include each individual license. Both licenses have copyright lines and the BSD license text can varies a little from license to license. In short IMO I think it's much better than before. I think this would be OK to merge and make another release candidate. Perhaps consider refining in future releases? > The LICENSE and NOTICE files don't list everything they should > -------------------------------------------------------------- > > Key: KAFKA-12602 > URL: https://issues.apache.org/jira/browse/KAFKA-12602 > Project: Kafka > Issue Type: Bug > Reporter: John Roesler > Assignee: John Roesler > Priority: Blocker > Fix For: 2.8.0, 2.7.1, 2.6.2 > > > [~jmclean] raised this on the mailing list: > [https://lists.apache.org/thread.html/r2df54c11c10d3d38443054998bc7dd92d34362641733c2fb7c579b50%40%3Cdev.kafka.apache.org%3E] > > We need to make the license file match what we are actually shipping in > source and binary distributions. -- This message was sent by Atlassian Jira (v8.3.4#803005)