jsancio commented on a change in pull request #10414:
URL: https://github.com/apache/kafka/pull/10414#discussion_r603413500
##########
File path: config/kraft/README.md
##########
@@ -119,8 +131,8 @@ If you encounter an issue, you might want to take a look at
the metadata log.
One way to view the metadata log is with kafka-dump-log.sh tool, like so:
~~~~
-[cmccabe@zeratul kafka3]$ ./bin/kafka-dump-log.sh --cluster-metadata-decoder
--skip-record-metadata --files
/tmp/self-managed-combined-logs/\@metadata-0/*.log
-Dumping /tmp/self-managed-combined-logs/@metadata-0/00000000000000000000.log
+[cmccabe@zeratul kafka3]$ ./bin/kafka-dump-log.sh --cluster-metadata-decoder
--skip-record-metadata --files /tmp/kraft-combined-logs/\@metadata-0/*.log
Review comment:
We should remove personal information.
```suggestion
$ ./bin/kafka-dump-log.sh --cluster-metadata-decoder --skip-record-metadata
--files /tmp/kraft-combined-logs/\@metadata-0/*.log
```
##########
File path: raft/bin/test-kraft-server-start.sh
##########
@@ -17,7 +17,7 @@
base_dir=$(dirname $0)
if [ "x$KAFKA_LOG4J_OPTS" = "x" ]; then
- export
KAFKA_LOG4J_OPTS="-Dlog4j.configuration=file:$base_dir/../config/raft-log4j.properties"
+ export
KAFKA_LOG4J_OPTS="-Dlog4j.configuration=file:$base_dir/../config/kraft-log4j.properties"
Review comment:
I like that we are renaming a few of the files in the module (`raft`).
How far do we want to take this? For example:
1. Should we rename the `raft` module to `kraft`?
2. Should we rename the `org.apache.kafka.raft` to `org.apache.kafka.kraft`?
Maybe this is okay since `kafka` precedes `raft`.
We don't have to do this in this PR. I am just interested to know if we are
only concerned with public facing names or should we also rename internal names?
cc @hachikuji
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
