ableegoldman commented on a change in pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#discussion_r601987024



##########
File path: 
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -589,11 +589,7 @@ boolean runLoop() {
             } catch (final TaskCorruptedException e) {
                 log.warn("Detected the states of tasks " + e.corruptedTasks() 
+ " are corrupted. " +
                         "Will close the task as dirty and re-create and 
bootstrap from scratch.", e);
-                try {
-                    taskManager.handleCorruption(e.corruptedTasks());
-                } catch (final TaskMigratedException taskMigrated) {

Review comment:
       Now that we've removed the commit, there's no reason for 
`handleCorruption` to ever throw TaskMigratedException. Bonus cleanup! 😄 
   
   unfortunately, we ended up needing to put it back in 😞 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to