ableegoldman opened a new pull request #10417:
URL: https://github.com/apache/kafka/pull/10417


   We've been amassing more and more `catch` blocks around the `runOnce` loop 
in the StreamThread's `runLoop`. Some of these have complex handling which is 
performed inside the catch block, such as `handleCorrupted` which itself can 
throw exceptions (see KAFKA-12523). 
   
   We also have a final `catch Throwable` block which invokes the exception 
handler on any unexpected exceptions. But since this is part of the same `try` 
as the other catch blocks, exceptions thrown from eg `handleCorrupted` will 
bypass the `catch Throwable` block and miss the exception handler. 
   
   This should probably be cherrypicked back to the 2.8 branch cc @vvcephei 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to